[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[abcde] Bug#110417: abcde: Option to do both id3v1 and id3v2 tags110417@bugs.debian.org
Package: abcde
Version: 2.0-1
Severity: wishlist
Hi,
This would be a nice feature to include IMHO - it makes the files
forwards-compatible and at the same time compatible with most current players
(ie ones that don't support id3v2).
Here is a patch:
--- /usr/bin/abcde Wed Aug 15 23:35:25 2001
+++ /usr/local/bin/abcde Tue Aug 28 13:32:14 2001
@@ -219,12 +219,18 @@
# ...except id3v2's -c is completely broken (there's a bug in id3lib
# v3.7.x keeping -c from being properly implemented)
if [ "$ID3TAGV" = "2" ]; then
- run_command tagtrack-$1 $TAGGER $TAGGEROPTS -A "$DALBUM" -a "$TRACKARTIST" \
+ run_command tagtrack-$1 $ID3V2 $ID3V2OPTS -A "$DALBUM" -a "$TRACKARTIST" \
-t "$TRACKNAME" -T "$1" "$ABCDETEMPDIR/track$1.$OUTPUTTYPE"
- else
- run_command tagtrack-$1 $TAGGER $TAGGEROPTS -c "$COMMENTOUTPUT" \
+ elif [ "$ID3TAGV" = "1" ]; then
+ run_command tagtrack-$1 $ID3 $ID3OPTS -c "$COMMENTOUTPUT" \
-A "$DALBUM" -a "$TRACKARTIST" -t "$TRACKNAME" -T "$1" "$ABCDETEMPDIR/track$1.$OUTPUTTYPE"
- fi
+ else # assume we want both tags
+ run_command tagtrack-$1 $ID3V2 $ID3V2OPTS -A "$DALBUM" -a "$TRACKARTIST" \
+ -t "$TRACKNAME" -T "$1" "$ABCDETEMPDIR/track$1.$OUTPUTTYPE"
+
+ run_command tagtrack-$1 $ID3 $ID3OPTS -c "$COMMENTOUTPUT" \
+ -A "$DALBUM" -a "$TRACKARTIST" -t "$TRACKNAME" -T "$1" "$ABCDETEMPDIR/track$1.$OUTPUTTYPE"
+ fi
else
# vorbiscomment can't do in-place modification, mv the file first
if [ -f "$ABCDETEMPDIR/track$1.$OUTPUTTYPE" -a \! -f "$ABCDETEMPDIR/track$1.uncommented.$OUTPUTTYPE" ]; then
[end of patch]
You would then add to the default config file (see below) a value for ID3TAGV
(1, 2 or both) - this should be there anyway.
-- System Information
Debian Release: testing/unstable
Kernel Version: Linux callisto 2.4.9 #1 Thu Aug 23 20:14:39 BST 2001 i686 unknown
Versions of the packages abcde depends on:
ii cd-discid 0.7-1 CDDB DiscID utility
ii cdda2wav 1.9-1 Creates WAV files from audio cd's
ii cdparanoia 3a9.8-4 An audio extraction tool for sampling CDs.
ii vorbis-tools 1.0rc1-1 Several Ogg Vorbis Tools
ii wget 1.6-2 utility to retrieve files from the WWW via H
--- Begin /etc/abcde.conf (modified conffile)
LAMEOPTS='-b 56 -v -h -V 2'
OUTPUTDIR=/e/rip/mp3/current
WAVOUTPUTDIR=/e/rip/wav
OUTPUTTYPE=mp3
OUTPUTFORMAT='${ARTISTFILE}/${ALBUMFILE}/${TRACKNUM}-${TRACKFILE}.${OUTPUTTYPE}'
VAOUTPUTFORMAT='${ARTISTFILE}/${TRACKNUM}-${TRACKFILE}.${OUTPUTTYPE}'
ID3TAGV=1
--- End /etc/abcde.conf
To unsubscribe: echo unsubscribe | mail abcde-request@whimsica.lly.org