[abcde] Bug#121771: Bug#121771: abcde race condition 121771@bugs.debian.org

[Robert Woodcock <rcw@debian.org>]

On Thu, Nov 29, 2001 at 09:55:30PM +0100, Richard van den Berg wrote:
> Abcde does a "checkstatus encodetrack" at line 1261, but after that goes 
> right ahead and removes the the tmp dir (if DOCLEAN is set). It is 
> possible that the encoding has finished, but the tagging (do_tag()) and 
> moving (do_move()) are not! Abcde should do a "checkstatus movetrack" 
> before removing the ABCDETEMPDIR!
> 
> I've lost some mp3 this way, especially when using the -r option and the 
> last file was being encoded remotely.

Hans-Joachim Baader noted the same thing about a month ago. His fix is
already in my 2.0.1 tree.

The big wait on 2.0.1 has been me trying to fix the SMP scheduler (see
Bug#111806 and friends). Since the new SMP code is Not There Yet(tm)
I'll have to back out those changes (which are rather non-trivial) before
releasing a new version.

FWIW I don't consider this release-critical.

The relevant part of Hans' patch follows:

--- /mnt/net/audio/abcde-2.0/abcde	Wed Aug 15 23:39:29 2001
+++ /usr/bin/abcde	Mon Oct 22 18:12:50 2001
@@ -1264,6 +1264,7 @@
 		if [ \! $PROCEED ]; then sleep 5; fi
 	done
 fi
+wait
 # Check to see if run_command logged any errors
 if [ -f "$ABCDETEMPDIR/errors" ]; then
 	echo "The following commands failed to run:"

:)
-- 
Robert Woodcock - rcw@debian.org
"Hiring assassins [...] is not something Americans are very good at."
	-- Henry Kissinger

To unsubscribe: echo unsubscribe | mail abcde-request@whimsica.lly.org