[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[abcde] Bug#126025: Bug#126025: abcde does not deal with *'s in CDDB data correctly.



On Thu, Dec 20, 2001 at 05:49:08PM -0500, Nick Martin wrote:
> When there are *'s in CDDB data, abcde actually expands them 
> to everything in the directory. 

Does not!

frantica:/tmp/John_Williams$ ls -1
Attacking_a_Star_Destroyer.ogg
Betrayal_at_Bespin_*.ogg
Carbon_Freeze_**___Darth_Vaders_Trap___Departure_of_Boba_Fett.ogg
Deal_with_the_Dark_Lord_*.ogg
Imperial_Starfleet_Deployed_*___City_In_The_Clouds.ogg
Landos_Palace.ogg
Rescue_from_Cloud_City___Hyperspace.ogg
The_Clash_of_Lightsabers.ogg
The_Imperial_March_(Darth_Vaders_Theme).ogg
Yoda_and_the_Force.ogg
Yodas_Theme.ogg
frantica:/tmp/John_Williams$

I learned my lesson with the security bug in abcde 1.0.1. :)

> Later, I found that the ID3 tags placed were correct, but the filenames created were not
> (I'm using my own mungefilename(), but it appears the default does not remove
> *'s.).

That's because * is a perfectly legitimate character in a filename, and it's
harmless if properly quoted.

Chances are your custom mungefilename() function is not properly quoting its
arguments. I recommend using "$@", not $@, not $*, etc...
-- 
Robert Woodcock - rcw@debian.org
"There is no right to fair use... Fair use is a defense against
infringement." -- Preston Padden, head of government relations, Disney

To unsubscribe: echo unsubscribe | mail abcde-request@whimsica.lly.org