[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[abcde] Bug#147726: abcde: not sh-compatible despite shebang line



Package: abcde
Version: 2.0.3-1
Severity: normal

The shebang line that starts the abcde script:

=====
#!/bin/sh
=====

claims that the script can be executed under Bourne-compatible shells.
However, there are "bashisms" throughout the script, primarily the
bash-style command interpolation operators, '$(' and ')'.  For the
script to be Bourne sh-compatible, these would need to be backquotes '`'
instead.

I haven't investigated for other structures that invalidate abcde's
claim of sh-ness, but it seems likely that they could exist.

Since the current style of the script is preferable -- sh-style
backquotes are ugly and prone to error -- I think the best resolution is
to change the shebang line to specify the bash shell:

=====
#!/bin/bash
=====


-- 
 \             "Those are my principles. If you don't like them I have |
  `\                                         others."  -- Groucho Marx |
_o__)                                                                  |
bignose@zip.com.au  F'print 9CFE12B0 791A4267 887F520C B7AC2E51 BD41714B

To unsubscribe: echo unsubscribe | mail abcde-request@whimsica.lly.org