[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[abcde] not-zapping-wavs.





I was looking for where to whine about my own patch for this function, amusing
that it comes up in such a timely manner.

My take on it was that it should not be linked to any extant function, because
folks might have gotten used to that, and get mad if it changes.  So I added a
new option, DELETEWAVS, which defaulted to 'n'.  This lets someone set
cleaning of WAV and cleaning of metadata orthogonally. 

Staring at the patch, I might use 'DOCLEANWAVS' and default it to 'y' instead
if I did it again.

Any opinions?




*** abcde       Thu Sep 12 13:10:16 2002
--- abcde.orig  Thu Sep 12 13:48:30 2002
***************
*** 297,306 ****
                ;;
        esac
        # Only remove .wav if the encoding succeeded
!       if [ "$DELETEWAVS" = "y" ] ; then
!           if checkerrors encodetrack-$1; then :; else
                rm -f "$IN"
-           fi
        fi
  }
  
--- 297,304 ----
                ;;
        esac
        # Only remove .wav if the encoding succeeded
!       if checkerrors encodetrack-$1; then :; else
                rm -f "$IN"
        fi
  }
  
***************
*** 901,908 ****
  READNICE=10
  VARIOUSARTISTS=n
  VARIOUSARTISTSTYLE=forward
- DELETEWAVS=y
- 
  
  # program paths - defaults to checking your $PATH
  LAME=lame
--- 899,904 ----

To unsubscribe: echo unsubscribe | mail abcde-request@whimsica.lly.org